Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.

Contributors can ignore this message.

Hi @gameleon-dev, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

build

This was applied as commit 0c35978.

Thank you for the PR!

I am trying to download thousand files. Whenever httpConnection.ConnectAsync() called new task, which waits for cancellation token to be cancelled, passed to Task.WhenAny construction. But if the cancellation token never triggered, task never finishes, hanging on cancellationToken.WaitHandle.WaitOne(), causing mono to create many threads, that never finish.

[Mono] [0xcc4d9a80] hill climbing, change max number of threads 130

@lexboss93

That is indeed an issue. It could be solved by creating a linked token to cancel the WaitOne like this:

CancellationTokenSource waitHandleSource = new CancellationTokenSource();
CancellationToken linkedToken = CancellationTokenSource.CreateLinkedTokenSource(waitHandleSource.Token, cancellationToken).Token;

await Task.WhenAny (
  httpConnection.ConnectAsync (),
  Task.Run (()=> { linkedToken.WaitHandle.WaitOne(); }))
.ConfigureAwait(false);

//The WhenAny task finished. If not already cancelled, cancel the WaitOne through its WaitHandleSource to prevent an orphaned thread
waitHandleSource.Cancel();

I have created a followup pull request at #344

Has this fix made it into a release yet?